Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

リファクタリング: SynthesisEngine内の関数のテストをファイル単位に切り出し #216

Closed
wants to merge 23 commits into from
Closed

リファクタリング: SynthesisEngine内の関数のテストをファイル単位に切り出し #216

wants to merge 23 commits into from

Conversation

aoirint
Copy link
Member

@aoirint aoirint commented Dec 3, 2021 •
edited
Loading

内容

#214 #215 の差分を含んでいるため、そちらを先にお願いします。

#215 で切り出したSynthesisEngine内の関数について、対応するテストを同様にファイル単位に切り出します。

関連 Issue

ref #215
ref #214
ref #199
ref #119

@coveralls
Copy link

coveralls commented Dec 3, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1539085149

  • 53 of 53 (100.0%) changed or added relevant lines in 8 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.9%) to 85.319%
Totals Coverage Status
Change from base Build 1535908500: 0.9%
Covered Lines: 616
Relevant Lines: 722
💛 - Coveralls

@github-actions
Copy link

github-actions bot commented Dec 3, 2021 •
edited
Loading

Coverage Result

Resultを開く
Name Stmts Miss Cover
voicevox_engine/init.py 0 0 coverage-100%
voicevox_engine/acoustic_feature_extractor.py 85 0 coverage-100%
voicevox_engine/full_context_label.py 160 7 coverage-96%
voicevox_engine/kana_parser.py 75 1 coverage-99%
voicevox_engine/model.py 70 7 coverage-90%
voicevox_engine/mora_list.py 4 0 coverage-100%
voicevox_engine/preset/Preset.py 12 0 coverage-100%
voicevox_engine/preset/PresetLoader.py 34 1 coverage-97%
voicevox_engine/preset/init.py 3 0 coverage-100%
voicevox_engine/synthesis_engine/init.py 4 0 coverage-100%
voicevox_engine/synthesis_engine/forwarder.py 69 62 coverage-10%
voicevox_engine/synthesis_engine/make_synthesis_engine.py 23 18 coverage-22%
voicevox_engine/synthesis_engine/mora/init.py 6 0 coverage-100%
voicevox_engine/synthesis_engine/mora/mora_to_text.py 7 0 coverage-100%
voicevox_engine/synthesis_engine/mora/pre_process.py 13 0 coverage-100%
voicevox_engine/synthesis_engine/mora/split_mora.py 10 0 coverage-100%
voicevox_engine/synthesis_engine/mora/to_flatten_moras.py 5 0 coverage-100%
voicevox_engine/synthesis_engine/mora/to_phoneme_data_list.py 6 0 coverage-100%
voicevox_engine/synthesis_engine/synthesis_engine.py 99 7 coverage-93%
voicevox_engine/utility/init.py 2 0 coverage-100%
voicevox_engine/utility/connect_base64_waves.py 35 3 coverage-91%
TOTAL 722 106 coverage-85%

@aoirint aoirint mentioned this pull request Dec 5, 2021
Closed
@aoirint
Copy link
Member Author

aoirint commented Dec 5, 2021 •
edited
Loading

#215 とセットなので、こちらもいったんクローズします！ （ #215 (comment) ）

@aoirint aoirint closed this Dec 5, 2021
@aoirint aoirint deleted the patch-synthesis-engine-module-test branch October 9, 2023 02:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aoirint @coveralls